Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct GHA workflow syntax in new cache-clearing action, be more resilient #20756

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Apr 4, 2024

In #20755, I had a typo: formatting the jobs as a list, with names keys... but that's the syntax for steps. Jobs need to be a dict with the ID as the key.

This also squashes any errors from rm -rf ....: on Mac, it seems that attempts to delete directories that the runner doesn't have permission for (particularly system ones in ~/Library/Caches). But that's fine, we'll still delete all of the caches created by "day-to-day" actions runs, which are the big ones.

(Why wasn't this caught in #20755? I attempted to run the workflow before merging, and got errors, but incorrectly assumed this was because the workflow didn't exist on main, but they were actually because it's invalid.)

This has now successfully run and cleared hundreds of gigs over two runs:

@huonw huonw added the category:internal CI, fixes for not-yet-released features, etc. label Apr 4, 2024
@huonw huonw changed the title Use correct GHA workflow syntax in new cache-clearing action Use correct GHA workflow syntax in new cache-clearing action, be more resilient Apr 4, 2024
@huonw huonw requested review from kaos and benjyw April 5, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants