-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure JVM docs. #20544
Restructure JVM docs. #20544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensible rearrangement!
I think this rename will mean existing links to https://www.pantsbuild.org/2.19/docs/java-and-scala and https://www.pantsbuild.org/2.19/docs/java-and-scala/kotlin will be broken, so it may be best to either:
- provide old pages to redirect (either here or in https://github.com/pantsbuild/pantsbuild.org/blob/main/old_site_redirects.js somehow)
- not cherry pick this to 2.19 (either deploying with the 2.19.1 release or before it). (It seems fine to break the pre-release links like https://www.pantsbuild.org/2.20/docs/java-and-scala.)
FWIW let's use a new file for new redirects. I'm hoping to keep that file strictly old -> new (simply for separations sake) |
Good idea re the redirects. So, how do I preview all this? Once I know how I will document it somewhere central. |
Generally, I would make edits on |
Previously the top-level menu was called "Java and Scala" and "Kotlin" was a subpage. Now the top-level is called "JVM" and there are two subpages - "Java and Scala", and "Kotlin".
67988f3
to
844e6ad
Compare
I have a redirects PR ready in pantsbuild/pantsbuild.org. IIUC, we can merge it once this is merged, since the redirecting files will only be created when we publish. |
Previously the top-level menu was called "Java and Scala" and "Kotlin" was a subpage. Now the top-level is called "JVM" and there are two subpages - "Java and Scala", and "Kotlin".
Previously the top-level menu was called "Java and Scala" and "Kotlin" was a subpage. Now the top-level is called "JVM" and there are two subpages - "Java and Scala", and "Kotlin".
Uses this to provide redirects required by pantsbuild/pants#20544
Previously the top-level menu was called "Java and Scala" and "Kotlin" was a subpage. Now the top-level is called "JVM" and there are two subpages - "Java and Scala", and "Kotlin". Co-authored-by: Benjy Weinberger <[email protected]>
Previously the top-level menu was called
"Java and Scala" and "Kotlin" was a subpage.
Now the top-level is called "JVM" and there
are two subpages - "Java and Scala", and "Kotlin".