Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve the help string for the global option 'PANTS_CONCURRENT'. #19822

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Moortiii
Copy link
Contributor

Previously the text made it seem as if enabling PANTS_CONCURRENT would force the use of pantsd and make concurrent invocations blocking, when in reality it's the other way around.

Previously the text made it seem as if enabling PANTS_CONCURRENT would
force the use of pantsd and make concurrent invocations blocking.
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huonw huonw added this to the 2.17.x milestone Sep 12, 2023
@huonw huonw merged commit 9bd3a30 into pantsbuild:main Sep 12, 2023
WorkerPants pushed a commit that referenced this pull request Sep 12, 2023
…'. (#19822)

Previously the text made it seem as if enabling PANTS_CONCURRENT would
force the use of pantsd and make concurrent invocations blocking, when
in reality it's the other way around.

Co-authored-by: Morten Hauge <[email protected]>
WorkerPants pushed a commit that referenced this pull request Sep 12, 2023
…'. (#19822)

Previously the text made it seem as if enabling PANTS_CONCURRENT would
force the use of pantsd and make concurrent invocations blocking, when
in reality it's the other way around.

Co-authored-by: Morten Hauge <[email protected]>
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.17.x

Successfully opened #19824.

✔️ 2.18.x

Successfully opened #19825.


Thanks again for your contributions!

🤖 Beep Boop here's my run link

huonw pushed a commit that referenced this pull request Sep 12, 2023
…'. (Cherry-pick of #19822) (#19825)

Previously the text made it seem as if enabling PANTS_CONCURRENT would
force the use of pantsd and make concurrent invocations blocking, when
in reality it's the other way around.

Co-authored-by: Morten Hauge <[email protected]>
Co-authored-by: Morten Hauge <[email protected]>
huonw pushed a commit that referenced this pull request Sep 12, 2023
…'. (Cherry-pick of #19822) (#19824)

Previously the text made it seem as if enabling PANTS_CONCURRENT would
force the use of pantsd and make concurrent invocations blocking, when
in reality it's the other way around.

Co-authored-by: Morten Hauge <[email protected]>
Co-authored-by: Morten Hauge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants