Remove memoization of the Paths intrinsic to reduce memory usage (Cherry-pick of #19689)
#19716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…19689) Remove memoization of the `Paths` intrinsic, since it is very memory intensive, and relatively cheap to recompute from its memoized inputs. Improves performance for `pants dependencies ::` in the Pants repo by 6%, and eliminates the `paths` Node line item mentioned on #19053, since it will no longer be held in memory by memoization. Fixes #19053.
stuhood
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove memoization of the
Pathsintrinsic, since it is very memory intensive, and relatively cheap to recompute from its memoized inputs.Improves performance for
pants dependencies ::in the Pants repo by 6%, and eliminates thepathsNode line item mentioned on #19053, since it will no longer be held in memory by memoization.Fixes #19053.