Remove tensorboard mapping from our default mapping (Cherry-pick of #19673)
#19699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`torch.utils.tensorboard` imports `tensorboard` (or dies trying). The original intent is "if a file imports it, it should receive a dependency on `tensorboard`". Unfortunately the actual behavior is that _only_ tensorboard is inferred (and not `torch`). Worse, an import from `tensorboard` is now ambiguous (because it's missing from the value). So we'll remove it and cherry-pick to 2.17.x (when it was introduced). Later we can fix the underlying issue of being able to model an import mapping to multiple packages. See #19672
huonw
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.utils.tensorboardimportstensorboard(or dies trying). The original intent is "if a file imports it, it should receive a dependency ontensorboard". Unfortunately the actual behavior is that only tensorboard is inferred (and nottorch). Worse, an import fromtensorboardis now ambiguous (because it's missing from the value).So we'll remove it and cherry-pick to 2.17.x (when it was introduced). Later we can fix the underlying issue of being able to model an import mapping to multiple packages.
See #19672