-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: layout tweak of caching info, remove toolchain :( and additional info about bazel-remote-cache #19299
Conversation
…l info about bazel-remote-cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the Pantsbuild Community. This looks like your first PR here.
We are so grateful for each an every contribution, big or small.
So thanks for spending your time and energy making this project better.
If you haven't gotten a reply in a week, feel free to gently comment "bump" to ping the project admins.
If you haven't already, feel free to come say hi on Slack.
If you have questions, or just want to surface this PR, check out the #development
channel.
(If you want to check it out without logging in, check out our Linen mirror)
Thanks again for this PR, and we'll be on the lookout for your next one 😄!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just punctuation nits. Thanks!
chore: apply suggestions, adding in missing . Co-authored-by: Benjy Weinberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! I will cherry-pick it to relevant docs versions.
…l info about bazel-remote-cache (#19299) Minor doc improvements.
…l info about bazel-remote-cache (#19299) Minor doc improvements.
…l info about bazel-remote-cache (#19299) Minor doc improvements.
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ❌ 2.15.xI was unable to cherry-pick this PR to 2.15.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. ❌ 2.16.xI was unable to cherry-pick this PR to 2.16.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. ❌ 2.17.xI was unable to cherry-pick this PR to 2.17.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. When you're done manually cherry-picking, please remove the Thanks again for your contributions! |
There wasn't actually a merge-conflict, the GHA code should've been ported by to the older branches. See: #19322 If you want, once these are fixed (after https://pantsbuild.slack.com/archives/C0D7TNJHL/p1686790197387729 is fixed) we can kick the bot to run on this PR. |
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ❌ 2.15.xI was unable to cherry-pick this PR to 2.15.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. ❌ 2.16.xI was unable to cherry-pick this PR to 2.16.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. ❌ 2.17.xI was unable to cherry-pick this PR to 2.17.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. When you're done manually cherry-picking, please remove the Thanks again for your contributions! |
Ok that failure was on me. One more before I turn on the seatbelt buckle sign. Hold on... |
…l info about bazel-remote-cache (#19299) Minor doc improvements.
…l info about bazel-remote-cache (#19299) Minor doc improvements.
…l info about bazel-remote-cache (#19299) Minor doc improvements.
TADA 🎉 |
Thanks! |
Haha, you just happened to be merging at the time where we're investing more in automation. And GHA isn't the easiest thing to get right 😅 |
Well, it's a nicer process than the "suggest edits" before so worth it imo 👍 (having tried both at the same time for this one!) As long as you're not quite at https://xkcd.com/1319 |
Only time will tell, honestly. I chalk up time spent to "learning". I found some interesting and novel ways of testing our GitHub Actions. I also started getting comfortable with https://github.com/actions/github-script and the GitHub Rest API |
…l info about bazel-remote-cache (Cherry-pick of #19299) (#19329) Minor doc improvements Co-authored-by: Mike Geeves <[email protected]>
…l info about bazel-remote-cache (Cherry-pick of #19299) (#19330) Minor doc improvements Co-authored-by: Mike Geeves <[email protected]>
…l info about bazel-remote-cache (Cherry-pick of #19299) (#19331) Minor doc improvements Co-authored-by: Mike Geeves <[email protected]>
Minor doc improvements