Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript: Add support for the pnpm package manager #18864

Merged
merged 15 commits into from
May 2, 2023
Merged

javascript: Add support for the pnpm package manager #18864

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
253a48a
feat: Parse package.json#packageManager property
tobni Apr 16, 2023
8286918
refactor: Split projects into tentative and finished types
tobni Apr 16, 2023
c332bcc
feat: Assign a package manager to NodeJSProjects
tobni Apr 16, 2023
e4a58fa
feat: Parametrize lockfile params
tobni Apr 16, 2023
342e95a
feat: Parametrize target package manager
tobni Apr 16, 2023
7ccb85a
feat: Prepare for project specific caches & env
tobni Apr 16, 2023
0d8bdcd
feat: Parametrize immutable installation args
tobni Apr 16, 2023
ae422db
refactor: Correct filename
tobni Apr 16, 2023
bbb22d9
fix: node_modules in correct directory in sandbox
tobni Apr 30, 2023
a8601a5
feat: Extend nodejs subsystem to support pnpm
tobni Apr 30, 2023
2cbaa9e
test: Extend integration tests with pnpm as runner
tobni Apr 30, 2023
66d4d18
fix: Use the correct argument for package specs
tobni Apr 30, 2023
d3914af
chore: Increase test timeout
tobni Apr 30, 2023
8e5f4c0
test: Only include the pnpm-worskpace.yaml in pnpm test
tobni Apr 30, 2023
a89cb0c
style: Run formatters after interactive rebase
tobni May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/python/pants/backend/javascript/goals/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ python_tests(
name="tests",
# The package.json files are inlined in ./test_integration_tests.py
overrides={
"test_integration_test.py": dict(dependencies=["./jest_resources", "./mocha_resources"]),
"test_integration_test.py": dict(
dependencies=["./jest_resources", "./mocha_resources"], timeout=120
),
},
)
2 changes: 1 addition & 1 deletion src/python/pants/backend/javascript/goals/jest_resources/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

resources(sources=["package-lock.json"])
resources(sources=["package-lock.json", "pnpm-lock.yaml"])
Loading