Use address as stable key when batching field sets in lint/test
#18725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests would have previously errored out, but were fixed by pantsbuild#18719. Adding them now before I change the batching key logic to be sure I don't re-break anything.
Closes pantsbuild#18566 Using `str(x)` as the stable batching key ends up using `repr` when `x` is a field set. This previously raised an exception in some cases - it's also an unintended behavior change introduced as part of the new partitioning logic in 2.15.x. Revert back to using `.address` as the partitioning key for field sets.
danxmoran
added
needs-cherrypick
category:bugfix
thejcannon
reviewed
Apr 12, 2023
thejcannon
approved these changes
Apr 13, 2023
cognifloyd
approved these changes
Apr 13, 2023
danxmoran
added a commit
to danxmoran/pants
that referenced
this pull request
Apr 13, 2023
…antsbuild#18725) Closes pantsbuild#18566 Using `str(x)` as the stable batching key ends up using `repr` when `x` is a field set. After pantsbuild#18719 this no longer raises an exception, but it's still an unintended behavior change introduced as part of the new partitioning logic in 2.15.x. Revert back to using `.address` as the partitioning key for field sets, and add regression tests.
danxmoran
added a commit
to danxmoran/pants
that referenced
this pull request
Apr 13, 2023
…antsbuild#18725) Closes pantsbuild#18566 Using `str(x)` as the stable batching key ends up using `repr` when `x` is a field set. After pantsbuild#18719 this no longer raises an exception, but it's still an unintended behavior change introduced as part of the new partitioning logic in 2.15.x. Revert back to using `.address` as the partitioning key for field sets, and add regression tests.
danxmoran
added a commit
that referenced
this pull request
Apr 13, 2023
…Cherry-pick of #18725) (#18733) Closes #18566 Using `str(x)` as the stable batching key ends up using `repr` when `x` is a field set. After #18719 this no longer raises an exception, but it's still an unintended behavior change introduced as part of the new partitioning logic in 2.15.x. Revert back to using `.address` as the partitioning key for field sets, and add regression tests.
danxmoran
added a commit
that referenced
this pull request
Apr 13, 2023
…Cherry-pick of #18725) (#18734) Closes #18566 Using `str(x)` as the stable batching key ends up using `repr` when `x` is a field set. After #18719 this no longer raises an exception, but it's still an unintended behavior change introduced as part of the new partitioning logic in 2.15.x. Revert back to using `.address` as the partitioning key for field sets, and add regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18566
Using
str(x)as the stable batching key ends up usingreprwhenxis a field set. After #18719 this no longer raises an exception, but it's still an unintended behavior change introduced as part of the new partitioning logic in 2.15.x.Revert back to using
.addressas the partitioning key for field sets, and add regression tests.