expose PANTS_VERSION and make it string-comparable #18573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #18528.
Very "dumb" implementation exposing it as a constant to all BUILD files. Unfortunately
packaging.version.Version
cannot be compared to strings, so I'm shimming it with a local Version class that allows this. I could do this in a more localized manner as this'll affect all uses of PANTS_SEMVER - but it seems like it'll reduce boilerplate in a lot of places. Happy to change based on opinion!We could also use an explicit comparator, or expose
Version
as well:or