Adds fields to capture stdout/stderr to experimental_run_in_sandbox
#18165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjrn
requested review from
kaos,
thejcannon and
stuhood
and removed request for
kaos
thejcannon
approved these changes
Feb 4, 2023
| @@ -389,6 +389,18 @@ class RunInSandboxArgumentsField(StringSequenceField): | |||
| help = f"Extra arguments to pass into the `{RunInSandboxRunnableField.alias}` field." | |||
|
|
|||
|
|
|||
| class RunInSandboxStdoutFilenameField(StringField): | |||
| alias = "stdout" | |||
There was a problem hiding this comment.
I'm only 80% joking when I say that the fields should be named 1> and 2> respectively 😄
There was a problem hiding this comment.
If only I weren't trying to steer people away from shell concepts :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
stdout=andstderr=fields toexperimental_run_in_sandbox, allowing users to include those streams in the output from such a target.Closes #18087.