docs: make tutorials to get started writing plugins visible on readme pages #18083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTereshenkov
commented
Jan 24, 2023
| @@ -1,8 +1,8 @@ | |||
| --- | |||
| title: "Advanced plugin concepts" | |||
| slug: "advanced plugin concepts" | |||
| slug: "advanced-plugin-concepts" | |||
There was a problem hiding this comment.
I think the slug is supposed to have dashes, so adding them
AlexTereshenkov
commented
Jan 24, 2023
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| title: "Create a new goal" | |||
| slug: "create-a-new-goal" | |||
| excerpt: "Getting started writing plugins for Pants by creating a new goal." | |||
| excerpt: "Getting started writing plugins for Pants by creating a new goal" | |||
There was a problem hiding this comment.
Removing the dot to make consistent with the rest of the tutorials.
There was a problem hiding this comment.
To me a well formed sentence ends with a period. Maybe add the missing period on the other excerpts instead?
kaos
approved these changes
Jan 25, 2023
benjyw
approved these changes
Jan 25, 2023
AlexTereshenkov
deleted the
docs/make-writing-plugins-tutorials-pages-visible
branch
AlexTereshenkov
added a commit
that referenced
this pull request
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all writing plugins tutorials visible on readme.com