Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure lockfile target exists before injecting a dependency to it. (Cherry-pick of #17365) #17505

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Ensure lockfile target exists before injecting a dependency to it. (Cherry-pick of #17365) #17505

merged 1 commit into from
Nov 9, 2022

Conversation

kaos
Copy link
Member

@kaos kaos commented Nov 9, 2022

Fixes #17343

Example warning message when the _lockfiles target is being shadowed:

09:25:43.12 [WARN] The synthetic lockfile target for 3rdparty/python/user_reqs.lock is being shadowed by the python_requirements target 3rdparty/python:python-default.

There will not be any dependency to the lockfile.

Resolve by either renaming the shadowing target, the resolve 'python-default' or moving the target or the lockfile to another directory.

@kaos
Ensure lockfile target exists before injecting a dependency to it. (#…
ffc1fc9 
…17365)

* Ensure lockfile target exists before injecting a dependency to it.

* add feature toggle for python lockfiles targets.

* Refactor requirement generators to use a common rule helper.

* Warn when lockfile targets are being shadowed.

* make ignored arg optional
@kaos kaos added the category:bugfix Bug fixes for released features label Nov 9, 2022
@kaos kaos requested review from Eric-Arellano and stuhood November 9, 2022 00:04
@kaos kaos merged commit 5125866 into 2.15.x Nov 9, 2022
@kaos kaos deleted the cherry-pick-17365-to-2.15.x branch April 23, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@Eric-Arellano Eric-Arellano Awaiting requested review from Eric-Arellano

Assignees
No one assigned
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaos @stuhood