Clarify how __defaults__ apply to target generators.
#17493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen a few users (including myself) be confused when `__defaults__` don't apply to generated targets. Add a blurb to the docs explicitly stating that defaults only apply _before_ target generation, so if you want to specify defaults for both generated & manually-written targets then you need to list both the generator & generated targets in the `__defaults__` dict.
kaos
approved these changes
Nov 8, 2022
danxmoran
added a commit
to danxmoran/pants
that referenced
this pull request
Nov 8, 2022
) I've seen a few users (including myself) be confused when `__defaults__` don't apply to generated targets. Add a blurb to the docs explicitly stating that defaults only apply _before_ target generation, so if you want to specify defaults for both generated & manually-written targets then you need to list both the generator & generated targets in the `__defaults__` dict. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
danxmoran
added a commit
to danxmoran/pants
that referenced
this pull request
Nov 8, 2022
) I've seen a few users (including myself) be confused when `__defaults__` don't apply to generated targets. Add a blurb to the docs explicitly stating that defaults only apply _before_ target generation, so if you want to specify defaults for both generated & manually-written targets then you need to list both the generator & generated targets in the `__defaults__` dict.
kaos
pushed a commit
that referenced
this pull request
Nov 8, 2022
…#17493) (#17498) Clarify how `__defaults__` apply to target generators. (#17493) I've seen a few users (including myself) be confused when `__defaults__` don't apply to generated targets. Add a blurb to the docs explicitly stating that defaults only apply _before_ target generation, so if you want to specify defaults for both generated & manually-written targets then you need to list both the generator & generated targets in the `__defaults__` dict. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
kaos
pushed a commit
that referenced
this pull request
Nov 8, 2022
…#17493) (#17499) Clarify how `__defaults__` apply to target generators. (#17493) I've seen a few users (including myself) be confused when `__defaults__` don't apply to generated targets. Add a blurb to the docs explicitly stating that defaults only apply _before_ target generation, so if you want to specify defaults for both generated & manually-written targets then you need to list both the generator & generated targets in the `__defaults__` dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17450
I've seen a few users (including myself) be confused when
__defaults__don't apply to generated targets. Add a blurb to the docs explicitly stating that defaults only apply before target generation, so if you want to specify defaults for both generated & manually-written targets then you need to list both the generator & generated targets in the__defaults__dict.