Begin migration to explicitly scoped environments #17155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
changed the title
stuhood
force-pushed
the
stuhood/environment-scoping
branch
6 times, most recently
from
a69bc66 to
c725edc
Compare
|
Only the top two commits are relevant: the rest are #17179. |
chrisjrn
reviewed
Oct 10, 2022
|
|
||
| Then, the `EnvironmentName` should be used at `Get` callsites which require an environment: | ||
| ```python | ||
| Get(TestResult, {field_set: TestFieldSet, environment_name: EnvironmentName}) |
There was a problem hiding this comment.
Where do the values for field_set and environment_name come from here?
There was a problem hiding this comment.
(in the cases that I've seen these, field_set and environment_name come from a non-obvious preceding Get; it looks similar in this case too)
There was a problem hiding this comment.
They come from the Get that is shown a few lines up.
I expect that one of our migration PRs should update this doc to reference itself as a complete example of migrating a goal.
stuhood
commented
Oct 10, 2022
This was referenced Oct 10, 2022
…equest an environment. [ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/environment-scoping
branch
from
c725edc to
7e66fc7
Compare
stuhood
added a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #17129: we would like
@goal_rules to eventually make their own decisions about which environments to use, generally by consuming targets to do so, but possibly also by pinning themselves to other environments via configuration.This change builds on #17179, and introduces a migration from
Goal.environment_migrated = {False => True}. All graph-introspection goals consume only the APIs which are pinned to the local environment by #17179, and so are trivially migrated here. Other goals trigger a deprecation warning like the following:Before calling #17129 done, we will migrate all internal goals to
Goal.environment_migrated=True.[ci skip-rust]
[ci skip-build-wheels]