Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM, Coinbase, and Astranis case studies #16805

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

cczona
Copy link
Member

@cczona cczona commented Sep 9, 2022

Including some general improvements to the page:

  • Move posts/case studies section to the top
  • Callout entry descriptions more prominently
  • Solicit submissions more invitingly and prominently

@cczona cczona requested review from chrisjrn and benjyw September 9, 2022 00:38
@cczona cczona marked this pull request as ready for review September 9, 2022 00:38
@cczona cczona changed the title Add IBM and Coinbase case studies Add IBM, Coinbase, and Astranis case studies Sep 9, 2022
@cczona cczona removed the request for review from chrisjrn September 9, 2022 16:49
@@ -4,10 +4,94 @@ slug: "media"
excerpt: "Learn more about Pants and related topics from these talks, posts and podcasts featuring Pants contributors and users."
hidden: false
createdAt: "2021-04-18T17:27:18.361Z"
updatedAt: "2022-04-05T22:02:38.457Z"
updatedAt: "2022-09-08T22:02:38.457Z"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own edification: is this edit necessary? I've made edits to other pages without corresponding updatedAt edits...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. If in-repo changes always override web changes regardless of the metadata, fab.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need me to remove the change to this line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good practice to do because it means the Readme.com "Updated 5 days ago" info at the bottom of the page will be accurate. It makes our site look more up-to-date

Comment on lines 29 to 30
August 12, 2022
[**Case Study**] "Astranis Case Study: Wrangling Python In a Monorepo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
August 12, 2022
[**Case Study**] "Astranis Case Study: Wrangling Python In a Monorepo"
August 12, 2022
[**Case Study**] "Astranis Case Study: Wrangling Python In a Monorepo"

Strangely enough, without these trailing spaces, it looks like this doesn't line break: https://github.com/pantsbuild/pants/blob/ca460081ef0d99996719764f936853af906cbed0/docs/markdown/Introduction/media.md#astranis-space-technologies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a difference between GH-flavored Markdown vs whatever flavor Readme's parser uses, because it renders a linebreak with the same edit: https://www.pantsbuild.org/v2.12/edit/media

But I've pushed a revision with the space restored, for the sake of consistency and review. That there is discrepancy between how GH and Readme renders Markdown is unfortunate.

## Posts & Articles

### Coinbase Blog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the newly added content is italicized, whereas most of the existing content is italicized. See the preview: https://github.com/pantsbuild/pants/blob/ca460081ef0d99996719764f936853af906cbed0/docs/markdown/Introduction/media.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: the italicized quote for Astranis wasn't closed properly

@stuhood stuhood merged commit 51f0675 into pantsbuild:main Sep 9, 2022
@stuhood stuhood added this to the 2.12.x milestone Sep 9, 2022
stuhood pushed a commit to stuhood/pants that referenced this pull request Sep 9, 2022
Including some general improvements to the page:

* Move posts/case studies section to the top
* Callout entry descriptions more prominently
* Solicit submissions more invitingly and prominently
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
stuhood pushed a commit to stuhood/pants that referenced this pull request Sep 9, 2022
Including some general improvements to the page:

* Move posts/case studies section to the top
* Callout entry descriptions more prominently
* Solicit submissions more invitingly and prominently
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
stuhood pushed a commit to stuhood/pants that referenced this pull request Sep 9, 2022
Including some general improvements to the page:

* Move posts/case studies section to the top
* Callout entry descriptions more prominently
* Solicit submissions more invitingly and prominently
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
@cczona cczona deleted the case-studies branch September 10, 2022 01:48
Eric-Arellano pushed a commit that referenced this pull request Sep 12, 2022
…16814)

Including some general improvements to the page:

* Move posts/case studies section to the top
* Callout entry descriptions more prominently
* Solicit submissions more invitingly and prominently
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

Co-authored-by: Carina C. Zona <[email protected]>
Eric-Arellano pushed a commit that referenced this pull request Sep 12, 2022
…16813)

Including some general improvements to the page:

* Move posts/case studies section to the top
* Callout entry descriptions more prominently
* Solicit submissions more invitingly and prominently
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

Co-authored-by: Carina C. Zona <[email protected]>
Eric-Arellano pushed a commit that referenced this pull request Sep 12, 2022
…16812)

Including some general improvements to the page:

* Move posts/case studies section to the top
* Callout entry descriptions more prominently
* Solicit submissions more invitingly and prominently

[ci skip-rust]
[ci skip-build-wheels]

Co-authored-by: Carina C. Zona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants