Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken shortlinks that invoked "docs:" instead of "doc:" #16804

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

cczona
Copy link
Member

@cczona cczona commented Sep 8, 2022

No description provided.

@cczona cczona requested a review from Eric-Arellano September 8, 2022 23:20
@cczona cczona marked this pull request as ready for review September 8, 2022 23:20
@cczona cczona requested review from chrisjrn and benjyw and removed request for Eric-Arellano September 9, 2022 00:11
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops!

@benjyw
Copy link
Contributor

benjyw commented Sep 9, 2022

Looks like there's another place in that file that is broken in the same way.

@benjyw
Copy link
Contributor

benjyw commented Sep 9, 2022

And a few in docs/markdown/Writing Plugins/rules-api/rules-api-process.md if you're feeling ambitious...

@cczona
Copy link
Member Author

cczona commented Sep 9, 2022

Fixes added

@cczona cczona changed the title fix broken link on Team page fix broken shortlinks that invoked "docs:" instead of "doc:" Sep 9, 2022
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stuhood stuhood added this to the 2.12.x milestone Sep 9, 2022
@stuhood stuhood merged commit 83c6a99 into pantsbuild:main Sep 9, 2022
stuhood pushed a commit to stuhood/pants that referenced this pull request Sep 9, 2022
…ild#16804)

Fix broken links.

[ci skip-rust]

[ci skip-build-wheels]
stuhood pushed a commit to stuhood/pants that referenced this pull request Sep 9, 2022
…ild#16804)

Fix broken links.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
stuhood pushed a commit to stuhood/pants that referenced this pull request Sep 9, 2022
…ild#16804)

Fix broken links.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
Eric-Arellano pushed a commit that referenced this pull request Sep 12, 2022
…pick of #16804) (#16811)

fix broken shortlinks that invoked "docs:" instead of "doc:" (#16804)

Fix broken links.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

Co-authored-by: Carina C. Zona <[email protected]>
Eric-Arellano pushed a commit that referenced this pull request Sep 12, 2022
…pick of #16804) (#16810)

Fix broken links.
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

Co-authored-by: Carina C. Zona <[email protected]>
Eric-Arellano pushed a commit that referenced this pull request Sep 12, 2022
…pick of #16804) (#16809)

Fix broken links.

[ci skip-rust]

[ci skip-build-wheels]

Co-authored-by: Carina C. Zona <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants