Support Docker custom tags via plugin hook #16662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonsodomin
added
needs-cherrypick
category:internal
benjyw
approved these changes
Aug 26, 2022
Merged
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Aug 31, 2022
Evaluates additional Docker image tags that may be provided via custom user-provided rules # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Aug 31, 2022
…16719) Evaluates additional Docker image tags that may be provided via custom user-provided rules Co-authored-by: A. Alonso Dominguez <[email protected]>
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
Evaluates additional Docker image tags that may be provided via custom user-provided rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16077 we added support to provide with additional Docker image tags via a custom union rule. However the Helm backend was not making use of that rule and therefore any tags provided in that way would be ignored when resolving Docker image references in Helm's post-renderer.
This PR adds support for retrieving the image tags that end users may provide using that mechanism.
[ci skip-rust]
[ci skip-build-wheels]