Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format build files #16650

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Format build files #16650

merged 2 commits into from
Aug 26, 2022

Conversation

asherf
Copy link
Member

@asherf asherf commented Aug 25, 2022

Ran ./pants fmt src/python/:: and black modified those build files...
there is probably something that needs to be enabled in CI so those
files don't regress.

Ran `./pants fmt src/python/::` and black modified those build files...
there is probably something that needs to be enabled in CI so those
files don't regress.
@asherf asherf added the category:internal CI, fixes for not-yet-released features, etc. label Aug 25, 2022
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./pants lint :: should catch this, along with ./pants --changed-since=<> lint. Although that only started working in Pants 2.13

@asherf
Copy link
Member Author

asherf commented Aug 25, 2022

./pants lint :: should catch this, along with ./pants --changed-since=<> lint. Although that only started working in Pants 2.13

it doesn't catch it on latest main...
Screen Shot 2022-08-25 at 4 36 35 PM

@Eric-Arellano
Copy link
Contributor

Oh, @thejcannon , _FmtBuildFilesRequest needs to be wired up to lint.py I think

@thejcannon
Copy link
Member

🤦

@thejcannon
Copy link
Member

Make an issue and assign me. Ill work on it ASAP, but might not finish today

@asherf
Copy link
Member Author

asherf commented Aug 26, 2022

CI Passed (previous failure was a flake)

@Eric-Arellano Eric-Arellano merged commit 87fa330 into pantsbuild:main Aug 26, 2022
@asherf asherf deleted the kramer branch August 26, 2022 20:15
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Aug 30, 2022
Ran `./pants fmt src/python/::` and black modified those build files...
there is probably something that needs to be enabled in CI so those
files don't regress.

[ci skip-rust]
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
cczona pushed a commit to cczona/pants that referenced this pull request Sep 1, 2022
Ran `./pants fmt src/python/::` and black modified those build files...
there is probably something that needs to be enabled in CI so those
files don't regress.

[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants