Add suport for string interpolation in Helm deployments #16611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonsodomin
added
category:new feature
backend: Docker
alonsodomin
force-pushed
the
helm_deployment_interpolation
branch
from
268b695 to
1a44305
Compare
kaos
reviewed
Aug 24, 2022
kaos
approved these changes
Aug 24, 2022
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Aug 31, 2022
…6611) Generalises the DockerInterpolationContext implementation making it available to other backends and implements interpolated values based on environment variables in helm_deployment targets. # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…6611) Generalises the DockerInterpolationContext implementation making it available to other backends and implements interpolated values based on environment variables in helm_deployment targets.
Eric-Arellano
added a commit
that referenced
this pull request
Sep 1, 2022
#16611) (#16723) Generalises the DockerInterpolationContext implementation making it available to other backends and implements interpolated values based on environment variables in helm_deployment targets. [ci skip-build-wheels] Co-authored-by: A. Alonso Dominguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalises the
DockerInterpolationContextimplementation making it available to other backends and implements interpolated values based on environment variables inhelm_deploymenttargets.Closes #16600
[ci skip-rust]
[ci skip-build-wheels]