Add missing help message to experimental backends
#16403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
added
needs-cherrypick
category:bugfix
Eric-Arellano
requested review from
alonsodomin,
sureshjoshi and
alexey-tereshenkov-oxb
alonsodomin
approved these changes
Aug 3, 2022
sureshjoshi
reviewed
Aug 4, 2022
| @@ -44,6 +45,9 @@ class JSSourceTarget(Target): | |||
|
|
|||
| class JSSourcesGeneratorSourcesField(JSGeneratorSourcesField): | |||
| default = tuple(f"*{ext}" for ext in JS_FILE_EXTENSIONS) | |||
| help = generate_multiple_sources_field_help_message( | |||
There was a problem hiding this comment.
🤯
I always thought the help auto-populated the defaults. I recall asking about it, and I guess I forgot the correct answer 🤦🏽♂️
There was a problem hiding this comment.
help used to be provided for MultipleSourcesField, but #15633 changed it so now you have to set it so that we can have better examples in the message. I think we forgot to update your code!
sureshjoshi
approved these changes
Aug 4, 2022
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Aug 12, 2022
Missing from pantsbuild#15633. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing from #15633.