[internal] Use f_globals instead of inspect.getmodule in collect_rules
#16357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] (cherry picked from commit 4c6c064) [ci skip-build-wheels]
chrisjrn
changed the title
f_globals instead of inspect.getmodule in collect_rulesf_globals instead of inspect.getmodule in collect_rules
|
(Given that this addresses |
stuhood
approved these changes
Jul 30, 2022
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…_rules` (pantsbuild#16357) While working on pantsbuild#7369, I discovered that `inspect.getmodule` requires relevant modules to exist on the filesystem. PyOxidizer's importer imports from memory, so finding rules by `inspect.getmodule` will not work. This change uses the `f_globals` attribute on the callling frame to get the global objects of the frame that invokes `collect_rules`. I believe this is functionally equivalent. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #7369, I discovered that
inspect.getmodulerequires relevant modules to exist on the filesystem. PyOxidizer's importer imports from memory, so finding rules byinspect.getmodulewill not work.This change uses the
f_globalsattribute on the callling frame to get the global objects of the frame that invokescollect_rules. I believe this is functionally equivalent.