Fix the experimental_run_shell_command example. #16286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The double-braces are incorrect, should be single braces (perhaps this used to be used as input for interplation?) 2) Use `find` instead of `tree` as many systems do not have the latter by default. Note that we may also want to remove this example entirely, as `testprojects/` is intended to be a home for inputs to integration tests. So either we should either write a test that uses this, or remove it. [ci skip-rust] [ci skip-build-wheels]
kaos
reviewed
Jul 23, 2022
| @@ -21,6 +21,6 @@ files(name="sources_directory", sources=["sources/**/*"]) | |||
|
|
|||
| experimental_run_shell_command( | |||
| name="cmd", | |||
| command='{{ tree {chroot}; echo "in: $CHROOT"; }} | tee output.log', | |||
| command='{ find {chroot} -type f; echo "in: $CHROOT"; } | tee output.log', | |||
There was a problem hiding this comment.
If this is not going through formatting, then the {chroot} part is hardly correct either.
There was a problem hiding this comment.
All I know is, it works (on macos and linux) without the double braces and does not work with them.
There was a problem hiding this comment.
Looks like we use string replace to replace {chroot} with the chroot path, not a call to format():
Eric-Arellano
approved these changes
Jul 27, 2022
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
1) The double-braces are incorrect, should be single braces (perhaps this used to be used as input for interplation?) 2) Use `find` instead of `tree` as many systems do not have the latter by default. Note that we may also want to remove this example entirely, as `testprojects/` is intended to be a home for inputs to integration tests. So either we should either write a test that uses this, or remove it. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(perhaps this used to be used as input for interplation?)
findinstead oftreeas many systems do not have thelatter by default.
Note that
testprojects/is intended to be a home for inputs tointegration tests. So possibly we should either write a test that
uses this example, or remove it.
[ci skip-rust]
[ci skip-build-wheels]