consume inits part of package object within the inner scope #16282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Jul 26, 2022
Comment on lines
+218
to
+221
| // TODO: should object already be recursive? | ||
| // an object is recursive if extends another type because we cannot figure out the provided types | ||
| // in the parents, we just mark the object as recursive (which is indicated by non-empty inits) | ||
| val recursive = !templ.inits.isEmpty |
There was a problem hiding this comment.
I'll wait for Stu to comment
There was a problem hiding this comment.
this piece of code is actually a copy from the Defn.Object, so not really new.
stuhood
approved these changes
Jul 26, 2022
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Aug 2, 2022
…ld#16282) package objects `inits` (the constructor + any extends)` should be in the scope of the package object vs other scala templates (class, object) that are in the package scope. This PR fixes that, by calling the apply on the inits within the package object scope. Fixes pantsbuild#16259 # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
Aug 2, 2022
…ld#16282) package objects `inits` (the constructor + any extends)` should be in the scope of the package object vs other scala templates (class, object) that are in the package scope. This PR fixes that, by calling the apply on the inits within the package object scope. Fixes pantsbuild#16259 # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Aug 2, 2022
…ick of #16282) (#16371) package objects `inits` (the constructor + any extends)` should be in the scope of the package object vs other scala templates (class, object) that are in the package scope. This PR fixes that, by calling the apply on the inits within the package object scope. fixes #16259 [ci skip-rust] [ci skip-build-wheels] Co-authored-by: Doron Somech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package objects
inits(the constructor + any extends)` should be in the scope of the package object vs other scala templates (class, object) that are in the package scope.This PR fixes that, by calling the apply on the inits within the package object scope.
fixes #16259