[internal] refactor Python ASDF support into a non-tool-specific rule #16202
Conversation
| @rule | ||
| async def resolve_asdf_tool_paths( | ||
| request: AsdfToolPathsRequest, build_root: BuildRoot | ||
| ) -> AsdfToolPathsResult: |
There was a problem hiding this comment.
Given the direct HOME and path access in the @rule_helper, can you mark this @_uncacheable_rule? I think that it's been a longstanding issue that ASDF edits won't invalidate correctly.
There was a problem hiding this comment.
Is there those path checks could use PathGlobs or an equivalent? I tried using PathGlobs in an earlier iteration of this PR to read .tool-versions, but the default --pants-ignore option ignores dot files in the build root.
There was a problem hiding this comment.
(Any fix to be able to use PathGlobs would be for the future, not this PR.)
There was a problem hiding this comment.
I don't think it would be possible to use PathGlobs for this, because some of these file paths are absolute (in $HOME). But labeling with a TODO that mentions #10842 would be good probably.
There was a problem hiding this comment.
Right, I had only tried it for the $BUILD_ROOT/.tool-versions path. Will do on TODO.
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
tdyas
force-pushed
the
asdf_refactor_into_nonspecific_rule
branch
from
d5988d3 to
e87c9b8
Compare
…pantsbuild#16202) Refactor Python ASDF into a non-tool-specific rule in anticipation of adding golang support. [ci skip-rust] [ci skip-build-wheels]
Refactor Python ASDF into a non-tool-specific rule in anticipation of adding golang support.
[ci skip-rust]
[ci skip-build-wheels]