Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] CI: add :: to update-build-files invocation #16142

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[internal] CI: add :: to update-build-files invocation #16142

merged 1 commit into from
Jul 12, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jul 12, 2022

./pants update-build-files wants target specs currently. Provide :: for the CI run to avoid the deprecation warning.

@tdyas tdyas added the category:internal CI, fixes for not-yet-released features, etc. label Jul 12, 2022
@tdyas tdyas requested review from stuhood and benjyw July 12, 2022 03:55
Eric-Arellano
Eric-Arellano approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch

@stuhood stuhood merged commit 9608e03 into pantsbuild:main Jul 12, 2022
@stuhood stuhood mentioned this pull request Jul 22, 2022
Merged
@tdyas tdyas deleted the ci_update_build_files_wants_targets branch February 20, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

@stuhood stuhood Awaiting requested review from stuhood

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdyas @benjyw @Eric-Arellano @stuhood