Optimize get_expanded_specs for StreamingWorkunit plugins
#16106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits are useful to review independently. |
tdyas
reviewed
Jul 9, 2022
…nt subjects. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/optimize-expand-specs
branch
3 times, most recently
from
cb6d6f6 to
1cb5c30
Compare
Eric-Arellano
approved these changes
Jul 11, 2022
[ci skip-rust] [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/optimize-expand-specs
branch
from
1cb5c30 to
9cce6e0
Compare
tdyas
approved these changes
Jul 11, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jul 12, 2022
…uild#16106) `StreamingWorkunit` plugins can use `get_expanded_specs` to capture the addresses associated with the input CLI specs for a run. But in cases with large numbers of input roots, this results in engine requests proportional to the number of targets in the repository. This change adjusts the algorithm for building the mapping from unexpanded addresses to expanded targets, and cleans up the `Scheduler.execute` API to allow for making requests with different product types in parallel. [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Jul 12, 2022
…-pick of #16106) (#16147) `StreamingWorkunit` plugins can use `get_expanded_specs` to capture the addresses associated with the input CLI specs for a run. But in cases with large numbers of input roots, this results in engine requests proportional to the number of targets in the repository. This change adjusts the algorithm for building the mapping from unexpanded addresses to expanded targets, and cleans up the `Scheduler.execute` API to allow for making requests with different product types in parallel. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamingWorkunitplugins can useget_expanded_specsto capture the addresses associated with the input CLI specs for a run. But in cases with large numbers of input roots, this results in engine requests proportional to the number of targets in the repository.This change adjusts the algorithm for building the mapping from unexpanded addresses to expanded targets, and cleans up the
Scheduler.executeAPI to allow for making requests with different product types in parallel.[ci skip-rust]
[ci skip-build-wheels]