Add __defaults__ BUILD file symbol
#15836
Conversation
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
|
This seems to work! I've put this up here for some early cursory remarks/feedback before jumping on writing a lot of tests. I'm currently holding my fingers tightly (very tightly) crossed, that we always parse all parent BUILD files, and not jump straight into the project subtree for some operations.. (seems to be the case but haven't verified) |
[ci skip-rust] [ci skip-build-wheels]
* Add `__str__` to parser `Registrar` rather than interhit from `str`. * Allow either `Registrar` or `str` as keys for the `__defaults__` dictionary.
[ci skip-rust] [ci skip-build-wheels]
|
OK, this is ready for review. I'm still slightly hazy on how to best ensure that the BUILD files are always parsed in an unbroken sequence. But from my code review, it seems that it might only be a There are a few open TODO questions in |
[ci skip-build-wheels]
[ci skip-build-wheels]
[ci skip-build-wheels]
[ci skip-build-wheels]
[ci skip-build-wheels]
| f"Valid fields are: {', '.join(sorted(valid_field_aliases))}.", | ||
| ) | ||
| # TODO: moved fields for TargetGenerators ? See: `Target._calculate_field_values()`. | ||
| # TODO: support parametrization ? |
There was a problem hiding this comment.
I think that parametrization should "just work", because the parametrize object is preserved, and not expanded until the target is actually constructed.
There was a problem hiding this comment.
I think the issue here would be that we do eager validation of the default values when freezing them.. so we would be passing a Parametrize object to the field.compute_value.
There was a problem hiding this comment.
Even so, we can avoid this validation, but get stuck on sticking the Parametrize instance in a FrozenDict does not work well:
E TypeError: Even though you are using a `FrozenDict`, the underlying values are not hashable. Please use hashable (and preferably immutable) types for the underlying values, e.g. use tuples instead of lists and use FrozenOrderedSet instead of set().
E
E Original error message: unhashable type: 'dict'
E
E Value: FrozenDict({'description': parametrize(a=desc A, b=desc B})
[ci skip-rust] [ci skip-build-wheels]
…f BUILD files. (#16089) Fix bug introduced in #15836 As reported by @ced-f on Slack: > I have a top level `django/BUILD` file which contains: > ```python > __defaults__({ > (python_tests): dict(dependencies=["django/django_core/settings.py"]) > }) > ``` > And a BUILD file under `django/sub/tests/classes/BUILD` which just defines: > ```python > python_tests( > name="tests", > ) > ``` > The dependencies goal in the subdirectory does not reference `django/django_core/settings.py` > If I extend the contents of `django/sub/tests/classes/BUILD` the dependency `django/django_core/settings.py` gets shown correctly: > ```python > __defaults__({ > (python_tests): dict(dependencies=["django/django_core/settings.py"]) > }) > python_tests( > name="tests", > ) > ```
Provide default field values for a set of targets in a particular subtree of a project using the
__defaults__symbol, using the same syntax as for theoverridesfield.Example:
The
__defaults__declaration should go at the top of the BUILD file, in order to apply to the targets in the same file. All BUILD files in subdirectories inherit the same defaults by default, but can be overridden/extended with their own__defaults__.Closes #13767.
Discussion: #15809.