Require setting description_of_origin with AddressInput and UnparsedAddressInputs
#15743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsedAddressInputs` [ci skip-rust] [ci skip-build-wheels]
tdyas
approved these changes
Jun 3, 2022
Eric-Arellano
commented
Jun 3, 2022
| @@ -33,6 +33,7 @@ async def inject_docker_dependencies( | |||
| UnparsedAddressInputs( | |||
| (v for v in dockerfile_info.from_image_build_args.to_dict().values() if v), | |||
| owning_address=dockerfile_info.address, | |||
| description_of_origin="TODO(#14468)", | |||
There was a problem hiding this comment.
I can try to figure this out, although @kaos if you have a chance, it would help.
| @@ -283,6 +283,7 @@ async def create_docker_build_context( | |||
| UnparsedAddressInputs( | |||
| dockerfile_build_args.values(), | |||
| owning_address=dockerfile_info.address, | |||
| description_of_origin="TODO(#14468)", | |||
There was a problem hiding this comment.
I can try to figure this out, although @kaos if you have a chance, it would help.
| UnparsedAddressInputs( | ||
| target_refs, | ||
| owning_address=address, | ||
| description_of_origin=f"TODO(#14468)", |
There was a problem hiding this comment.
I can figure this one out after lunch. The tricky part is it could be from provides field or entry_points field.
| Targets, UnparsedAddressInputs([request.pants_address], owning_address=None) | ||
| Targets, | ||
| UnparsedAddressInputs( | ||
| [request.pants_address], owning_address=None, description_of_origin="TODO(#14468)" |
| @@ -46,7 +46,7 @@ def address_input(self) -> AddressInput: | |||
| f"Unknown URI scheme for BSP BuildTargetIdentifier. Expected scheme `pants`, but URI was: {self.uri}" | |||
| ) | |||
| raw_addr = self.uri[len("pants:") :] | |||
| return AddressInput.parse(raw_addr) | |||
| return AddressInput.parse(raw_addr, description_of_origin="TODO(#14468)") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to enrich the error messages for #14468, which will be done in a followup.
Some of the callers are not yet implemented, but that's fine because this doesn't update error messages yet except for two cases that should not happen in the wild.
[ci skip-rust]
[ci skip-build-wheels]