Correctly describe the origin of invalid specs, e.g. --paths-from
#15730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels] [ci skip-rust] [ci skip-rust]
Eric-Arellano
commented
Jun 2, 2022
| @@ -166,7 +166,9 @@ class _ParseOneBSPMappingRequest: | |||
| async def parse_one_bsp_mapping(request: _ParseOneBSPMappingRequest) -> BSPBuildTargetInternal: | |||
| specs_parser = SpecsParser() | |||
| specs = specs_parser.parse_specs( | |||
| request.definition.addresses, convert_dir_literal_to_address_literal=False | |||
| request.definition.addresses, | |||
| description_of_origin=f"the BSP mapping {request.name}", | |||
There was a problem hiding this comment.
@tdyas is this an accurate description?
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
I can't reproduce the failing test that caused it. Ran the tests 10 times. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
It was a lie to hardcode "CLI arguments".
Most of these rules should never error because we only error if the directory of the CLI specs do not exist, and we programmatically compute the specs based on already existing targets. But still, this gives us much better debugging if those assumptions are violated.
This also unblocks us from #14468. The
Specswill be able to pass down theirdescription_of_origintoAddressInputfor much better errors with invalidAddressLiteralSpecs.[ci skip-build-wheels]