Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install Pex-style lockfile when no requirements used #15706

Merged
merged 1 commit into from
May 31, 2022

Conversation

Eric-Arellano
Copy link
Contributor

Closes #15705.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano added needs-cherrypick category:bugfix Bug fixes for released features labels May 31, 2022
@Eric-Arellano Eric-Arellano added this to the 2.11.x milestone May 31, 2022
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano Eric-Arellano merged commit 5445aa7 into pantsbuild:main May 31, 2022
@Eric-Arellano Eric-Arellano deleted the pex-binary-no-3rdparty branch May 31, 2022 17:38
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request May 31, 2022
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request May 31, 2022
Eric-Arellano added a commit that referenced this pull request May 31, 2022
…ck of #15706) (#15707)

Don't install Pex-style lockfile when no requirements used (#15706)

Closes #15705.

[ci skip-rust]
[ci skip-build-wheels]
Eric-Arellano added a commit that referenced this pull request May 31, 2022
…ck of #15706) (#15708)

Don't install Pex-style lockfile when no requirements used (#15706)

Closes #15705.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pex_binary with no 3rdparty deps ends up including ALL 3rdparty deps after enabling resolves
2 participants