Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint only finds targets and files if the relevant linters were specified (Cherry-pick of #15579) #15601

Merged
merged 2 commits into from
May 23, 2022

Conversation

Eric-Arellano
Copy link
Contributor

Before:

❯ hyperfine -w 1 -r 5 './pants --no-pantsd lint --only=docformatter ::'
Benchmark 1: ./pants --no-pantsd lint --only=docformatter ::
  Time (mean ± σ):      6.907 s ±  0.651 s    [User: 5.204 s, System: 0.876 s]
  Range (min … max):    6.299 s …  7.950 s    5 runs

After:

❯ hyperfine -w 1 -r 5 './pants --no-pantsd lint --only=docformatter ::'
Benchmark 1: ./pants --no-pantsd lint --only=docformatter ::
  Time (mean ± σ):      6.478 s ±  0.111 s    [User: 4.995 s, System: 0.779 s]
  Range (min … max):    6.369 s …  6.666 s    5 runs

[ci skip-rust]
[ci skip-build-wheels]

…ified (pantsbuild#15579)

Before:

```
❯ hyperfine -w 1 -r 5 './pants --no-pantsd lint --only=docformatter ::'
Benchmark 1: ./pants --no-pantsd lint --only=docformatter ::
  Time (mean ± σ):      6.907 s ±  0.651 s    [User: 5.204 s, System: 0.876 s]
  Range (min … max):    6.299 s …  7.950 s    5 runs
```

After:

```
❯ hyperfine -w 1 -r 5 './pants --no-pantsd lint --only=docformatter ::'
Benchmark 1: ./pants --no-pantsd lint --only=docformatter ::
  Time (mean ± σ):      6.478 s ±  0.111 s    [User: 4.995 s, System: 0.779 s]
  Range (min … max):    6.369 s …  6.666 s    5 runs
```

[ci skip-rust]
[ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano merged commit e8c7697 into pantsbuild:2.12.x May 23, 2022
@Eric-Arellano Eric-Arellano deleted the cp-lazy-lint-12 branch May 23, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants