Fix Scala inference not inferring a symbol name after a function call #15565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thank you so much. I've pinged more qualified reviewers and kicked off CI |
stuhood
reviewed
May 20, 2022
Comment on lines
277
to
278
| # Select with Apply as Qualifier only yield the name after the Apply | ||
| ".toInt", |
There was a problem hiding this comment.
This seems like a bug... is it avoidable by recursing on a different portion of node.qual?
There was a problem hiding this comment.
it is actually not related to the qual, it existed even before my pr, that the behavior of extractName when the qual is not one of the cases in the match, but let me try and fix that in another commit.
stuhood
changed the title
|
We are currently running pants from source using our branch because we need #15583. So we made a temporary patch to the ScalaParser: Bottom line, cherry-picking for 2.11 is not required for us. |
stuhood
pushed a commit
to stuhood/pants
that referenced
this pull request
May 23, 2022
…d#15565) This fix solved most of our compilation errors without adding explicit dependencies. The problem is if the `qual` part of the Select term is Apply term the ScalaParser doesn't build the full name, only the outer term name and the dependency cannot be inferred automatically. This PR continues and visits the `qual` node of the select term. [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
May 23, 2022
… (Cherry-pick of #15565) (#15603) The problem is if the `qual` part of the Select term is Apply term the ScalaParser doesn't build the full name, only the outer term name and the dependency cannot be inferred automatically. This PR continues and visits the `qual` node of the select term. [ci skip-rust] [ci skip-build-wheels] Co-authored-by: Doron Somech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix solved most of our compilation errors without adding explicit dependencies.
The problem is if the
qualpart of the Select term is Apply term the ScalaParser doesn't build the full name, only the outer term name and the dependency cannot be inferred automatically. This PR continues and visits thequalnode of the select term.