Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning off export of Python tools like black (Cherry-pick of #15509) #15511

Merged
merged 1 commit into from
May 17, 2022

Conversation

Eric-Arellano
Copy link
Contributor

Closes #15502.

I considered adding an option to turn off export of all tools via [export].tools = false, but the modeling didn't work out well. The generic export goal has zero idea what a "tool" is, and that's a Python abstraction. The requester of this feature (@kaos ) said he's happy with this to start.

[ci skip-rust]
[ci skip-build-wheels]

…5509)

Closes pantsbuild#15502.

I considered adding an option to turn off export of _all_ tools via `[export].tools = false`, but the modeling didn't work out well. The generic `export` goal has zero idea what a "tool" is, and that's a Python abstraction. The requester of this feature (@kaos ) said he's happy with this to start.

[ci skip-rust]
[ci skip-build-wheels]
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@Eric-Arellano Eric-Arellano merged commit 64df05a into pantsbuild:2.12.x May 17, 2022
@Eric-Arellano Eric-Arellano deleted the cp-export-12 branch May 17, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants