jvm: fix incorrect check for root-only ClasspathEntryRequest implementations (Cherry pick of #15494)
#15496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entations (pantsbuild#15494) The conditional logic which checked for a root-only `ClasspathEntryRequest` implementation in a non-root position looked at a loop variable which could be unrelated to the compatible `ClasspathEntryRequest` implementation at issue. Solution: Check the root-only status of the compatible `ClasspathEntryRequest` implementation and avoid checking the loop variable. h/t to @stuhood for spotting the bug. pantsbuild/example-kotlin#1 (comment) [ci skip-rust] [ci skip-build-wheels]
stuhood
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional logic which checked for a root-only
ClasspathEntryRequestimplementation in a non-root position looked at a loop variable which could be unrelated to the compatibleClasspathEntryRequestimplementation at issue.Solution: Check the root-only status of the compatible
ClasspathEntryRequestimplementation and avoid checking the loop variable.h/t to @stuhood for spotting the bug. pantsbuild/example-kotlin#1 (comment)
[ci skip-rust]
[ci skip-build-wheels]