don't generate default tool lockfiles #15488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
May 16, 2022
|
Sounds like this needs cherrypick to 2.12. Added labels |
|
CI failure seems like it is from PR about to be reverted. |
tdyas
force-pushed
the
jvm_fix_default_tool_lockfiles
branch
from
630e36f to
5c781f9
Compare
|
I still need to write a test for this. |
added 2 commits
May 16, 2022 18:12
[ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
force-pushed
the
jvm_fix_default_tool_lockfiles
branch
from
5c781f9 to
cd8be50
Compare
tdyas
pushed a commit
to tdyas/pants
that referenced
this pull request
May 17, 2022
Do not generate tool lockfiles if the tool is using the default lockfile. The bug was probably introduced by me in pantsbuild#15242. Closes pantsbuild#15460. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
pushed a commit
that referenced
this pull request
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not generate tool lockfiles if the tool is using the default lockfile. The bug was probably introduced by me in #15242.
Closes #15460.
[ci skip-rust]