Move get_git deprecation to start in 2.14.0.dev0
#15423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le` via a `Get` in a backwards-compatible way. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
May 12, 2022
asherf
approved these changes
May 12, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
May 12, 2022
Bump `get_git` deprecation to start in `2.14.0.dev0`, because it is challenging to consume a `@rule` via a `Get` in a backwards-compatible way. A `QueryRule` can be installed conditionally, but not a `Get` (since they will always be detected via `@rule`'s static analysis). [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
May 13, 2022
…15423) (#15437) Bump `get_git` deprecation to start in `2.14.0.dev0`, because it is challenging to consume a `@rule` via a `Get` in a backwards-compatible way. A `QueryRule` can be installed conditionally, but not a `Get` (since they will always be detected via `@rule`'s static analysis). [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
get_gitdeprecation to start in2.14.0.dev0, because it is challenging to consume a@rulevia aGetin a backwards-compatible way (see #15421). AQueryRulecan be installed conditionally, but not aGet(since they will always be detected via@rule's static analysis).[ci skip-rust]
[ci skip-build-wheels]