Fix non-determinism of package_data in generated setup.py files (Cherry-pick of #15292)
#15300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antsbuild#15292) As described in pantsbuild#14843, (some) tests which consumed `runtime_package_dependencies` would always miss the cache. This was because the dists generated for each run were slightly different, which came down to the `package_data` generated for `resources` being in a non-deterministic order due to iterating over a `set`. See pantsbuild#14195 (comment) for some thoughts on how to avoid this kind of issue in the future. Fixes pantsbuild#14843: warm CI times should drop by about 1 minute from ~3m to ~2m. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
|
Will wait to land until after |
Eric-Arellano
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #14843, (some) tests which consumed
runtime_package_dependencieswould always miss the cache.This was because the dists generated for each run were slightly different, which came down to the
package_datagenerated forresourcesbeing in a non-deterministic order due to iterating over aset. See #14195 (comment) for some thoughts on how to avoid this kind of issue in the future.Fixes #14843: warm CI times should drop by about 1 minute from ~3m to ~2m.