Fix a bug in the python venv export logic. #15294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
benjyw
commented
May 2, 2022
| @@ -86,39 +85,28 @@ async def export_virtualenv( | |||
| request.root_python_targets, python_setup | |||
| ) or InterpreterConstraints(python_setup.interpreter_constraints) | |||
|
|
|||
| min_interpreter = interpreter_constraints.snap_to_minimum(python_setup.interpreter_universe) | |||
There was a problem hiding this comment.
This interpreter was not the one being used in practice! This was the legacy of the previous implementation.
benjyw
commented
May 2, 2022
| @@ -217,6 +217,12 @@ def __post_init__(self): | |||
| f"Given platform constraints {self.platforms} for internal only pex request: " | |||
| f"{self}." | |||
| ) | |||
| if self.internal_only and self.complete_platforms: | |||
There was a problem hiding this comment.
We check this for platforms above, but neglected to check it for complete_platforms.
jsirois
approved these changes
May 2, 2022
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
May 2, 2022
Previously, and partly as a legacy of an older implementation, we acted as if the requirements pex had interpreter constraints baked into it. We relied on this when detecting the version of that interpreter. But a requirements pex is internal-only, and so has no interpreter constraints. So in practice we were picking whatever interpreter was used to run the pex, and that may not have been compatible with the relevant constraints. Now we always use a compatible interpreter. [ci skip-rust] [ci skip-build-wheels]
|
Will cherry-pick this to 2.12.x now, but will wait until we get 2.11.0 out before I cherrypick to 2.11.x, to target a 2.11.1 release. |
Good call. Thanks. #15298. |
benjyw
added a commit
that referenced
this pull request
May 2, 2022
Previously, and partly as a legacy of an older implementation, we acted as if the requirements pex had interpreter constraints baked into it. We relied on this when detecting the version of that interpreter. But a requirements pex is internal-only, and so has no interpreter constraints. So in practice we were picking whatever interpreter was used to run the pex, and that may not have been compatible with the relevant constraints. Now we always use a compatible interpreter. [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
May 2, 2022
…15294) Previously, and partly as a legacy of an older implementation, we acted as if the requirements pex had interpreter constraints baked into it. We relied on this when detecting the version of that interpreter. But a requirements pex is internal-only, and so has no interpreter constraints. So in practice we were picking whatever interpreter was used to run the pex, and that may not have been compatible with the relevant constraints. Now we always use a compatible interpreter. [ci skip-rust] [ci skip-build-wheels]
benjyw
added a commit
that referenced
this pull request
May 3, 2022
…5307) Previously, and partly as a legacy of an older implementation, we acted as if the requirements pex had interpreter constraints baked into it. We relied on this when detecting the version of that interpreter. But a requirements pex is internal-only, and so has no interpreter constraints. So in practice we were picking whatever interpreter was used to run the pex, and that may not have been compatible with the relevant constraints. Now we always use a compatible interpreter. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, and partly as a legacy of an older implementation, we acted as if the requirements pex
had interpreter constraints baked into it. We relied on this when detecting the version of that interpreter.
But a requirements pex is internal-only, and so has no interpreter constraints. So in practice we
were picking whatever interpreter was used to run the pex, and that may not have been compatible
with the relevant constraints.
Now we always use a compatible interpreter.
[ci skip-rust]
[ci skip-build-wheels]