Fix the placement of the pex verbosity args. #15243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pex subcommands mechanism registers the -v flag twice, once at the global position and once for each subcommand. In practice the second registration shadows the first in the resulting options object. This may be something to address in pex (the global -v does nothing so we should probably not register it), but the practical upshot for Pants is that we have to provide the -v flag after the subcommand name for it to take effect. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Apr 25, 2022
|
See corresponding pex issue: pex-tool/pex#1735 |
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Apr 25, 2022
The pex subcommands mechanism registers the -v flag twice, once at the global position and once for each subcommand. In practice the second registration shadows the first in the resulting options object. This may be something to address in pex (the global -v does nothing so we should probably not register it), but the practical upshot for Pants is that we have to provide the -v flag after the subcommand name for it to take effect. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Apr 25, 2022
The pex subcommands mechanism registers the -v flag twice, once at the global position and once for each subcommand. In practice the second registration shadows the first in the resulting options object. This may be something to address in pex (the global -v does nothing so we should probably not register it), but the practical upshot for Pants is that we have to provide the -v flag after the subcommand name for it to take effect. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Apr 26, 2022
…15249) The pex subcommands mechanism registers the -v flag twice, once at the global position and once for each subcommand. In practice the second registration shadows the first in the resulting options object. This may be something to address in pex (the global -v does nothing so we should probably not register it), but the practical upshot for Pants is that we have to provide the -v flag after the subcommand name for it to take effect. [ci skip-rust] [ci skip-build-wheels] Co-authored-by: Benjy Weinberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pex subcommands mechanism registers the -v flag twice,
once at the global position and once for each subcommand.
The net effect is that the second registration shadows the first in
the resulting options object.
This may be something to address in pex (the global -v does nothing
so we should probably not register it), but the practical upshot
for Pants is that we have to provide the -v flag after the subcommand
name for it to take effect.
[ci skip-rust]
[ci skip-build-wheels]