Fix lockfile generation for duplicate jvm_artifact targets with jar fields.
#15219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
… `Target`s. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
Apr 21, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Apr 22, 2022
…r` fields. (pantsbuild#15219) pantsbuild#15218 demonstrates a fairly obscure issue where a mostly-duplicated `jvm_artifact` target which defined a `jar` field would find that the first few fields in an `ArtifactRequirement` were equal before attempting to compare a `JvmArtifactJarSourceField` field, which would fail. Rather than sorting `ArtifactRequirement` instances, we can instead ensure that the input targets are sorted. Fixes pantsbuild#15218. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Apr 22, 2022
…r` fields. (pantsbuild#15219) Rather than sorting `ArtifactRequirement` instances, we can instead ensure that the input targets are sorted. Fixes pantsbuild#15218. [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Apr 22, 2022
…r` fields. (Cherry-pick of #15219) (#15230) #15218 demonstrates a fairly obscure issue where a mostly-duplicated `jvm_artifact` target which defined a `jar` field would find that the first few fields in an `ArtifactRequirement` were equal before attempting to compare a `JvmArtifactJarSourceField` field, which would fail. Rather than sorting `ArtifactRequirement` instances, we can instead ensure that the input targets are sorted. Fixes #15218.
stuhood
added a commit
that referenced
this pull request
Apr 22, 2022
…r` fields. (Cherry-pick of #15219) (#15232) #15218 demonstrates a fairly obscure issue where a mostly-duplicated `jvm_artifact` target which defined a `jar` field would find that the first few fields in an `ArtifactRequirement` were equal before attempting to compare a `JvmArtifactJarSourceField` field, which would fail. Rather than sorting `ArtifactRequirement` instances, we can instead ensure that the input targets are sorted. Fixes #15218. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15218 demonstrates a fairly obscure issue where a mostly-duplicated
jvm_artifacttarget which defined ajarfield would find that the first few fields in anArtifactRequirementwere equal before attempting to compare aJvmArtifactJarSourceFieldfield, which would fail.Rather than sorting
ArtifactRequirementinstances, we can instead ensure that the input targets are sorted.Fixes #15218.