Fix Pylint config check strings #14946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
added
the
category:internal
stuhood
reviewed
Mar 29, 2022
thejcannon
changed the title
Co-authored-by: Stu Hood <[email protected]>
stuhood
approved these changes
Mar 29, 2022
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 29, 2022
- According to https://pylint.pycqa.org/en/latest/user_guide/run.html the section _starts with_ `tool.pylint`. (E.g. `[tool.pylint.MASTER]`) - It's `.pylintrc` not `.pylinrc` (missing "t") # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
Does this need to go back to |
|
Can't hurt? |
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 29, 2022
- According to https://pylint.pycqa.org/en/latest/user_guide/run.html the section _starts with_ `tool.pylint`. (E.g. `[tool.pylint.MASTER]`) - It's `.pylintrc` not `.pylinrc` (missing "t")
Eric-Arellano
added a commit
that referenced
this pull request
Mar 29, 2022
- According to https://pylint.pycqa.org/en/latest/user_guide/run.html the section _starts with_ `tool.pylint`. (E.g. `[tool.pylint.MASTER]`) - It's `.pylintrc` not `.pylinrc` (missing "t") [ci skip-rust] Co-authored-by: Joshua Cannon <[email protected]>
Eric-Arellano
added a commit
that referenced
this pull request
Mar 30, 2022
- According to https://pylint.pycqa.org/en/latest/user_guide/run.html the section _starts with_ `tool.pylint`. (E.g. `[tool.pylint.MASTER]`) - It's `.pylintrc` not `.pylinrc` (missing "t") [ci skip-rust] Co-authored-by: Joshua Cannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tool.pylint. (E.g.[tool.pylint.MASTER]).pylintrcnot.pylinrc(missing "t")