Write test reports to a standard location under the distdir. #14929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now users can turn reporting on with --report, without having to fiddle with the location, but can still modify that location if necessary. This is similar to how coverage reports work. Also fixes an issue where we hardcoded `dist/` as the default for coverage reports, instead of using distdir. Note that user can, as before, set a custom path outside the distdir (as they can for coverage reports), but this change makes it more likely the reports will go to dist/, which is probably gitignored, instead of to some arbitrary location that may not be. Basically it makes it easier to turn out reports without creating complications, and makes use of dist/ more standardized. [ci skip-rust] [ci skip-build-wheels]
|
Addresses #14806 |
stuhood
approved these changes
Mar 28, 2022
asherf
approved these changes
Mar 28, 2022
Eric-Arellano
approved these changes
Mar 28, 2022
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Jun 28, 2022
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now users can turn reporting on with --report, without having
to fiddle with the location, but can still modify that location
if necessary. This is similar to how coverage reports work.
Also fixes an issue where we hardcoded
dist/as the default forcoverage reports, instead of using distdir.
Note that user can, as before, set a custom path outside the
distdir (as they can for coverage reports), but this change makes
it more likely the reports will go to dist/, which is probably gitignored.
[ci skip-rust]
[ci skip-build-wheels]