Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support package goal for Helm charts #14797

Merged
merged 12 commits into from
Mar 17, 2022

Conversation

alonsodomin
Copy link
Contributor

Builds upon initial implementation of the Helm backend implementing the package goal for helm_chart targets.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

src/python/pants/backend/helm/goals/package.py Outdated Show resolved Hide resolved
src/python/pants/backend/helm/goals/package.py Outdated Show resolved Hide resolved
@Eric-Arellano Eric-Arellano requested review from stuhood and tdyas March 17, 2022 01:12
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/python/pants/backend/helm/target_types.py Outdated Show resolved Hide resolved
src/python/pants/backend/helm/target_types.py Outdated Show resolved Hide resolved
@Eric-Arellano Eric-Arellano enabled auto-merge (squash) March 17, 2022 16:09
@Eric-Arellano Eric-Arellano merged commit 24777ab into pantsbuild:main Mar 17, 2022
@alonsodomin alonsodomin deleted the helm_package_charts branch March 18, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants