scala: support multiple scala versions #14425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 9, 2022 19:03
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
|
Still working on a test but this approach is ready for review at least. I have a separate change in the works to automatically add scala-libary requirements to a resolve when the resolve is being generated. |
[ci skip-rust] [ci skip-build-wheels]
|
Added test. |
tdyas
commented
Feb 10, 2022
added 3 commits
February 10, 2022 08:25
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
|
@stuhood: any comments on the updated help text wording? |
Going to land; will make any wording comments in a follow-on. |
No, it looked good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for multiple Scala versions in the same repository. Each resolve will be assigned a single Scala version.
Scala requires that all Scala-compiled jars on a classpath (i.e, a resolve) be "compatible" with one another (regardless of whether they are third-party jars or jars compiled from first-party sources). For Scala 2.x versions, for example, "compatibility" means that all Scala-compiled jars were compiled with the same minor version of Scala (i.e., 2.12). We can maintain this "Scala compatibility" property for a resolve by assigning the resolve a single Scala version which ensures that there is single Scala version that all of the third-party jars must be compatible with and that all first-party sources are compiled with.
Introduce the
--scala-version-for-resolveoption to implement the mapping from resolve to Scala version. The--scala-versionoption is deprecated and will be used as a fallback if the Scala version for a particular resolve is not set in--scala-version-for-resolve.Closes #13994.