[internal] Hook up [python-repos] and manylinux to Pex lockfile generation
#14282
Conversation
…eneration # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
There was a problem hiding this comment.
Huzzah! Thanks @jsirois for your work on Pex lockfiles! It's exciting to close the loop here from when you first pointed out Poetry's insufficiencies with [python-repos].
| extra_args=( | ||
| "--output=lock.json", | ||
| "--no-emit-warnings", |
There was a problem hiding this comment.
We use this when building a PEX, so I figure we should use it here too.
There was a problem hiding this comment.
Hm. I wonder why...
Given that we only render the output when we fail, having warnings rendered on failure might be useful...?
There was a problem hiding this comment.
There was a problem hiding this comment.
You're of course free to add args piecemeal, and maybe you have ~all the arguments Pants passes to Pex wired now (not sure from my phone) but lock create does accept all resolve options, including --platform, etc. Those will need to all get passed to be able to create the same PEX with the lock that you would without the lock.
With platforms, I'd appreciate your feedback on #12612 (comment) when you have a chance. I think I'm still confused on locks & platforms.
Divergences from our
So, |
|
|
Thank you, that's helpful!
I agree. And possibly we don't get rid of it during this awkward in-between period. I'm still thinking about what the migration path is going to look like. |
| extra_args=( | ||
| "--output=lock.json", | ||
| "--no-emit-warnings", |
There was a problem hiding this comment.
Hm. I wonder why...
Given that we only render the output when we fail, having warnings rendered on failure might be useful...?
[ci skip-rust]