Rename PythonModule to PythonModuleOwnersRequest
#14276
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
FYI @thejcannon , this touches some code you've been working on. Speaking of which, any thoughts if this should be "internal" vs Plugin API Change for the changelog? Do we think anyone is using |
| resolve_field = tgt[PythonResolveField] | ||
| resolve_field.validate(python_setup) | ||
| resolve = resolve_field.value_or_default(python_setup) |
There was a problem hiding this comment.
I don't like how many lines this is taking to do. I'm thinking about ways to simplify this.
src/python/pants/backend/python/dependency_inference/module_mapper_test.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/dependency_inference/module_mapper_test.py
Outdated
Show resolved
Hide resolved
Strictly speaking, feel free to call it out as an API change because it is. I have no issues with the current instability because it results in drastic improvements. However, instability without documentation is worse than instability with docs. 😉 And because of the instability (and the docs needing TLC) I'd imagine most (if not all) plugin authors have messaged in Slack at one time or another. So I'd say if you're not aware of anyone using that mapping then there's likely no one using it. |
Eric-Arellano
changed the title
PythonModule to PythonModuleOwnersRequest
[ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Follow up to #14034. For
python_testandpex_binary, we now use infer dependencies onpython_requirementtargets from the sameresolve. (If[python].enable_resolves = true). This implements the feature sketched out at #13621.Follow ups will apply this restriction to
python_source,python_aws_lambda, andpython_google_cloud_function. I have no idea how this should work withpython_distributionthough...Note that you can only set one
resolve, even thoughpython_sourcefor now has thecompatible_resolvesfield to let you have >1. See discussion at #14034 (comment).