Replace coursier-resolve goal with generate-lockfiles
#14211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
force-pushed
the
generate-lockfiles-jvm-user
branch
from
51b4354 to
c6e3aa5
Compare
Eric-Arellano
commented
Jan 19, 2022
| @@ -0,0 +1,142 @@ | |||
| # Copyright 2021 Pants project contributors (see CONTRIBUTORS.md). | |||
| # Licensed under the Apache License, Version 2.0 (see LICENSE). | |||
|
|
|||
There was a problem hiding this comment.
These tests are very similar to coursier_integration_test.py, but they're more direct. We don't run a goal_rule anymore, and they instead test the rules directly.
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Jan 19, 2022
Co-authored-by: Stu Hood <[email protected]>
…files-jvm-user # Conflicts: # src/python/pants/backend/java/compile/javac_test.py # src/python/pants/jvm/goals/coursier.py # src/python/pants/jvm/goals/coursier_integration_test.py # src/python/pants/jvm/goals/lockfile.py # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip-rust]