-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jvm] Expose additional JVM backends and symbols #13943
Merged
stuhood
merged 3 commits into
pantsbuild:main
from
stuhood:stuhood/enable-google-java-format
Dec 21, 2021
Merged
[jvm] Expose additional JVM backends and symbols #13943
stuhood
merged 3 commits into
pantsbuild:main
from
stuhood:stuhood/enable-google-java-format
Dec 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eric Java formatting rules. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Dec 21, 2021
tdyas
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. thanks!
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
changed the title
[jvm] Fix enabling
[jvm] Expose additional JVM backends and symbols
Dec 21, 2021
google_java_format
Heads up: have tacked on another backend-enabling-oversight here. Will land without additional review, but FYI. |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Dec 21, 2021
The `google_java_format` backend was not registering itself (or the generic Java formatting rules), and the `scalac_plugin` target type wasn't exposed. [ci skip-rust] [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Dec 21, 2021
… (#13947) The `google_java_format` backend was not registering itself (or the generic Java formatting rules), and the `scalac_plugin` target type wasn't exposed. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
google_java_format
backend was not registering itself (or the generic Java formatting rules), and thescalac_plugin
target type wasn't exposed.[ci skip-rust]
[ci skip-build-wheels]