Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm] Expose additional JVM backends and symbols #13943

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

stuhood
Copy link
Member

@stuhood stuhood commented Dec 21, 2021

The google_java_format backend was not registering itself (or the generic Java formatting rules), and the scalac_plugin target type wasn't exposed.

[ci skip-rust]
[ci skip-build-wheels]

…eric Java formatting rules.

[ci skip-rust]

[ci skip-build-wheels]
@stuhood stuhood added this to the 2.9.x milestone Dec 21, 2021
Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. thanks!

@stuhood stuhood enabled auto-merge (squash) December 21, 2021 20:00
@stuhood stuhood disabled auto-merge December 21, 2021 20:00
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood changed the title [jvm] Fix enabling google_java_format [jvm] Expose additional JVM backends and symbols Dec 21, 2021
@stuhood
Copy link
Member Author

stuhood commented Dec 21, 2021

Heads up: have tacked on another backend-enabling-oversight here. Will land without additional review, but FYI.

@stuhood stuhood enabled auto-merge (squash) December 21, 2021 20:09
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood merged commit 3f78814 into pantsbuild:main Dec 21, 2021
@stuhood stuhood deleted the stuhood/enable-google-java-format branch December 21, 2021 22:34
stuhood added a commit to stuhood/pants that referenced this pull request Dec 21, 2021
The `google_java_format` backend was not registering itself (or the generic Java formatting rules), and the `scalac_plugin` target type wasn't exposed.

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this pull request Dec 21, 2021
… (#13947)

The `google_java_format` backend was not registering itself (or the generic Java formatting rules), and the `scalac_plugin` target type wasn't exposed.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants