Fix tailor not setting the name field (Cherry-pick of #13913)
#13924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were setting the target name to always be `docker`, but not setting the kwargs so the name _actually_ ended up being the default of the directory name. This caused tailor to not properly handle collisions in the target name. This fixes it by removing the gotcha entirely. Now, `core/goals/tailor.py` determines if the `name` field will be set or not based on whether the `name` is the default of the directory name. [ci skip-rust] [ci skip-build-wheels]
kaos
approved these changes
Dec 20, 2021
|
PR target branch says |
|
Oh shoot, good catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the target name to always be
docker, but not setting the kwargs so the name actually ended up being the default of the directory name. This caused tailor to not properly handle collisions in the target name.This fixes it by removing the gotcha entirely. Now,
core/goals/tailor.pydetermines if thenamefield will be set or not based on whether thenameis the default of the directory name.[ci skip-rust]
[ci skip-build-wheels]