Ensure that Tree contents are uploaded after creation. #13008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-build-wheels]
|
Although this should be picked to |
stuhood
force-pushed
the
stuhood/upload-tree-contents
branch
from
b1b54df to
f8bd865
Compare
jsirois
approved these changes
Sep 25, 2021
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Sep 25, 2021
…13008) We currently do not upload the file `Digest`s referenced by `Tree`s, which will later cause a "missing file" to be reported during eager fetch of a cache entry. As discussed in pantsbuild#13006: we should likely have native support for storing and uploading `Tree`s, but this change fixes the immediate issue in a cherry-pickable way. [ci skip-build-wheels]
stuhood
added a commit
that referenced
this pull request
Sep 25, 2021
#13008) (#13009) We currently do not upload the file `Digest`s referenced by `Tree`s, which will later cause a "missing file" to be reported during eager fetch of a cache entry. As discussed in #13006: we should likely have native support for storing and uploading `Tree`s, but this change fixes the immediate issue in a cherry-pickable way.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not upload the file
Digests referenced byTrees, which will later cause a "missing file" to be reported during eager fetch of a cache entry.As discussed in #13006: we should likely have native support for storing and uploading
Trees, but this change fixes the immediate issue in a cherry-pickable way.[ci skip-build-wheels]